Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop node 10 and node 15 #12220

Merged
merged 6 commits into from
Feb 9, 2022
Merged

chore: drop node 10 and node 15 #12220

merged 6 commits into from
Feb 9, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 5, 2022 •
edited
Loading

Summary

They're both EOL.

Also set range of Node 16 version to first LTS release.

Test plan

Green CI

@SimenB SimenB added this to the Jest 28 milestone Jan 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022 •
edited
Loading

Codecov Report

Merging #12220 (10ea2d8) into main (9bcd565) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12220      +/-   ##
==========================================
- Coverage   67.31%   67.29%   -0.02%     
==========================================
  Files         329      329              
  Lines       17336    17327       -9     
  Branches     5074     5071       -3     
==========================================
- Hits        11669    11660       -9     
  Misses       5634     5634              
  Partials       33       33
Impacted Files Coverage Δ
packages/jest-core/src/collectHandles.ts 71.83% <ø> (ø)
...kages/jest-worker/src/workers/NodeThreadsWorker.ts 93.61% <ø> (ø)
packages/jest-worker/src/workers/messageParent.ts 0.00% <0.00%> (-35.72%) ⬇️
packages/jest-haste-map/src/crawlers/node.ts 93.45% <100.00%> (-1.04%) ⬇️
packages/jest-resolve/src/isBuiltinModule.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcd565...10ea2d8. Read the comment docs.

@marcelltoth marcelltoth mentioned this pull request Feb 2, 2022
Merged
@SimenB SimenB mentioned this pull request Feb 4, 2022
Merged
@mrazauskas
Copy link
Contributor

Possible candidate for Node 10 support clean up:

https://github.com/facebook/jest/blob/9bcd5659555317f95af2aa6623ceb64997a6386f/packages/jest-worker/src/workers/messageParent.ts#L11-L28

@SimenB
Copy link
Member Author

SimenB commented Feb 5, 2022

Ah, good call!

This was referenced Feb 5, 2022
Merged
Merged
SimenB
SimenB commented Feb 5, 2022
View reviewed changes
packages/jest-haste-map/src/crawlers/node.ts
@@ -74,27 +74,22 @@ function find(
callback(result);
return;
}
// node < v10.10 does not support the withFileTypes option, and
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's another node 10 thing below we could simplify, but I'm not 100% sure what the correct solution is there (https://github.com/facebook/jest/pull/9514/files/9f0aae7c79090cc5275aa7b91e2bb5a02d2c36f0#r800046825)

@SimenB SimenB force-pushed the drop-old-node branch 2 times, most recently from 10ea2d8 to b4bf20c Compare February 9, 2022 07:25
@SimenB SimenB merged commit 7e484b2 into jestjs:main Feb 9, 2022
@SimenB SimenB deleted the drop-old-node branch February 9, 2022 08:41
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
Jest 28
Development

Successfully merging this pull request may close these issues.
4 participants
@SimenB @codecov-commenter @mrazauskas @facebook-github-bot